Skip to content

chore: remove zstd and markAsUncloneable feature probes#4968

Merged
mcollina merged 1 commit intonodejs:mainfrom
trivikr:runtime-features
Apr 5, 2026
Merged

chore: remove zstd and markAsUncloneable feature probes#4968
mcollina merged 1 commit intonodejs:mainfrom
trivikr:runtime-features

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 4, 2026

This relates to...

Follow-up to raising the minimum supported Node.js version to >=22.19.0

Rationale

Now that undici only supports Node.js versions where node:zlib exposes zstd support and node:worker_threads exposes markAsUncloneable, the remaining runtime probes for those APIs are obsolete. Removing them simplifies the code and makes the tests reflect the actual supported runtime matrix.

Changes

  • remove zstd and markAsUncloneable from the runtime feature probe registry
  • make zstd decompression unconditional in fetch and the decompress interceptor
  • import markAsUncloneable directly in the Web IDL utilities
  • update tests to stop conditionally skipping zstd and uncloneable coverage
  • remove the outdated type comment implying markAsUncloneable is only available on some newer Node.js versions

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

Removes compatibility branches for Node.js versions older than the supported minimum

Status

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.96%. Comparing base (48c7cf3) to head (b2091ed).

Files with missing lines Patch % Lines
lib/util/runtime-features.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4968      +/-   ##
==========================================
- Coverage   92.96%   92.96%   -0.01%     
==========================================
  Files         111      111              
  Lines       35864    35826      -38     
==========================================
- Hits        33342    33304      -38     
  Misses       2522     2522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ad6b0c6 into nodejs:main Apr 5, 2026
33 checks passed
@trivikr trivikr deleted the runtime-features branch April 5, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants