add missing exports for browsers #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add/port a couple of test to our browser suite https://github.com/nodejs/readable-stream/tree/master/test/browser? As an example: https://github.com/nodejs/readable-stream/blob/master/test/parallel/test-stream-pipeline.js and https://github.com/nodejs/readable-stream/blob/master/test/parallel/test-stream-finished.js. |
|
I tried to do that, but failed. Cannot invest more time on that, sorry |
|
Anyone else that could do it? Would be cool to have this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing exports, mentioned in #408
There should be tests, that would have catched the problem beforehand, but I did not figure out how to add those in reasonable time. I appreciate, if someone more experienced with this project adds those tests.