fix for sync writes in older node

[calvinmetcalf]

possible fix for #187

[mcollina]

BTW, we should really use setImmediate with 0.10.

$ node -v
v0.10.41
~/Repositories/fastbench (master)
$ node example.js
benchSetTimeout*1000: 1333ms
benchSetImmediate*1000: 4ms
benchSetTimeout*1000: 1327ms
benchSetImmediate*1000: 3ms

[calvinmetcalf]

setImmediate is not available in node 0.10

[mcollina]

I think setImmediate was introduced in v0.10

$ node -v
v0.10.41
~
$ node
> setImmediate(console.log, 'hello world')
{ _idleNext:
   { _idleNext: [Circular],
     _idlePrev: [Circular] },
  _idlePrev:
   { _idleNext: [Circular],
     _idlePrev: [Circular] },
  _onImmediate: [Function] }
> hello world

undefined
>
(^C again to quit)
> ~
$

[calvinmetcalf]

hm in that case, that will simplify things

On Sat, Feb 27, 2016 at 12:32 PM Matteo Collina [email protected]
wrote:

I think setImmediate was introduced in v0.10

$ node -v
v0.10.41
~
$ node

setImmediate(console.log, 'hello world')
{ _idleNext:
{ _idleNext: [Circular],
_idlePrev: [Circular] },
_idlePrev:
{ _idleNext: [Circular],
_idlePrev: [Circular] },
_onImmediate: [Function] }
hello world

undefined

(^C again to quit)
~
$

—
Reply to this email directly or view it on GitHub
#188 (comment)
.

[calvinmetcalf]

I am happy to be wrong about this 😄

[calvinmetcalf]

how do we feel about this one?

[mcollina]

LGTM

[calvinmetcalf]

rebased will merge when green

On Fri, Mar 11, 2016 at 12:08 PM Matteo Collina [email protected]
wrote:

LGTM

—
Reply to this email directly or view it on GitHub
#188 (comment)
.