Skip to content

Conversation

avivkeller
Copy link
Member

Improves our ESLint configuration as follows;

  • Performs the TypeScript ESLint and globals setup at root (as multiple packages use this)
  • Matches doc-kit for some root rules
  • Enables stylistic TypeScript rules, to maintain consistency
  • Stops using Legacy ESLint syntax
  • Uses eslint-react over eslint-plugin-react, since it has better TS support, and claims to be 7x faster than eslint-plugin-react

Note: pnpm removed the comments from the workspace file. Do we want to re-add these, or not?, since pnpm may remove them again.

@avivkeller avivkeller requested review from a team as code owners August 29, 2025 20:42
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 29, 2025 8:42pm

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.56%. Comparing base (03e8834) to head (a035a8c).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/site/hooks/react-generic/useSiteNavigation.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8122      +/-   ##
==========================================
- Coverage   76.59%   76.56%   -0.04%     
==========================================
  Files         115      115              
  Lines        9595     9595              
  Branches      321      322       +1     
==========================================
- Hits         7349     7346       -3     
- Misses       2245     2248       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good effort done here ✨

@ovflowd ovflowd added this pull request to the merge queue Aug 31, 2025
Merged via the queue into main with commit 39d1229 Aug 31, 2025
12 checks passed
@ovflowd ovflowd deleted the improve-eslint branch August 31, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants