-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(🏳️🌈): update logo design #7866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7866 +/- ##
==========================================
- Coverage 75.46% 75.45% -0.02%
==========================================
Files 101 101
Lines 8306 8306
Branches 218 218
==========================================
- Hits 6268 6267 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
4b023fc
to
6b81db3
Compare
Ah, I totally missed that there's a JSX component for the logo as well. Please hold. |
@nodejs/tsc so that you are aware |
Actually logo changes need to be approved by the Foundation. |
@nodejs/social (maybe they can Code own these files?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs further approval from the foundation or TSC. Blocking until there is clarity.
I don't seem to have access to those, could we get screenshots and/or a TLDR to understand the motivations? |
Yes, of course it needs. I've even mentioned that above :) |
@aduh95 TL:DR from the discussions is that the current pride logo doesn’t apply the same shading as the original logo, which has been rectified in this PR. |
i think the logo looks good. if we want to have it on our social channels though, we will need a version with only the hexagon since the full node.js mark doesnt fit in the profile photo. |
Dismissing, as foundation has approved
Description
Updates the pride variation of the Node.js logo based on discussions in the Node.js Discord.
(https://discord.com/channels/425824580918181889/1354159950787772426/1383499959168663693)
Validation
Pride variation of the logo renders nicely on the site.
Related Issues
Follow-up to #7861.
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.