Skip to content

test: favor === over in == in http test #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions test/parallel/test-http.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
'use strict';
require('../common');
var assert = require('assert');
var http = require('http');
var url = require('url');
const assert = require('assert');
const http = require('http');
const url = require('url');

var responses_sent = 0;
var responses_recvd = 0;
var body0 = '';
var body1 = '';

var server = http.Server(function(req, res) {
if (responses_sent == 0) {
assert.equal('GET', req.method);
assert.equal('/hello', url.parse(req.url).pathname);
const server = http.Server(function(req, res) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you are doing this, why don't you change the requires as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye That's right. Let me do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye I will finish it today.

if (responses_sent === 0) {
assert.strictEqual('GET', req.method);
assert.strictEqual('/hello', url.parse(req.url).pathname);

console.dir(req.headers);
assert.equal(true, 'accept' in req.headers);
assert.equal('*/*', req.headers['accept']);
assert.strictEqual(true, 'accept' in req.headers);
assert.strictEqual('*/*', req.headers['accept']);

assert.equal(true, 'foo' in req.headers);
assert.equal('bar', req.headers['foo']);
assert.strictEqual(true, 'foo' in req.headers);
assert.strictEqual('bar', req.headers['foo']);
}

if (responses_sent == 1) {
assert.equal('POST', req.method);
assert.equal('/world', url.parse(req.url).pathname);
if (responses_sent === 1) {
assert.strictEqual('POST', req.method);
assert.strictEqual('/world', url.parse(req.url).pathname);
this.close();
}

Expand All @@ -41,28 +41,28 @@ var server = http.Server(function(req, res) {
server.listen(0);

server.on('listening', function() {
var agent = new http.Agent({ port: this.address().port, maxSockets: 1 });
const agent = new http.Agent({ port: this.address().port, maxSockets: 1 });
http.get({
port: this.address().port,
path: '/hello',
headers: {'Accept': '*/*', 'Foo': 'bar'},
agent: agent
}, function(res) {
assert.equal(200, res.statusCode);
assert.strictEqual(200, res.statusCode);
responses_recvd += 1;
res.setEncoding('utf8');
res.on('data', function(chunk) { body0 += chunk; });
console.error('Got /hello response');
});

setTimeout(function() {
var req = http.request({
const req = http.request({
port: server.address().port,
method: 'POST',
path: '/world',
agent: agent
}, function(res) {
assert.equal(200, res.statusCode);
assert.strictEqual(200, res.statusCode);
responses_recvd += 1;
res.setEncoding('utf8');
res.on('data', function(chunk) { body1 += chunk; });
Expand All @@ -74,12 +74,11 @@ server.on('listening', function() {

process.on('exit', function() {
console.error('responses_recvd: ' + responses_recvd);
assert.equal(2, responses_recvd);
assert.strictEqual(2, responses_recvd);

console.error('responses_sent: ' + responses_sent);
assert.equal(2, responses_sent);
assert.strictEqual(2, responses_sent);

assert.equal('The path was /hello', body0);
assert.equal('The path was /world', body1);
assert.strictEqual('The path was /hello', body0);
assert.strictEqual('The path was /world', body1);
});