build: compile bundled uvwasi conditionally #59622
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the same for `--shared-uvwasi` as nodejs#55886 does for `ada`, `simdjson`, and `simdutf`. Refs: nodejs#55886
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Aug 27, 2025
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4e0af20 |
targos
pushed a commit
that referenced
this pull request
Aug 28, 2025
This does the same for `--shared-uvwasi` as #55886 does for `ada`, `simdjson`, and `simdutf`. Refs: #55886 PR-URL: #59622 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same for
--shared-uvwasias #55886 does forada,simdjson, andsimdutf.Refs: #55886