Skip to content

Conversation

wlgh1553
Copy link
Contributor

@wlgh1553 wlgh1553 commented Aug 4, 2025

Implements the TODO comment for making the keep-alive timeout buffer configurable.

What changed

  • Removed hardcoded HTTP_AGENT_KEEP_ALIVE_TIMEOUT_BUFFER = 1000
  • Added configurable keepAliveTimeoutBuffer option to Agent with validation
  • Added tests
  • Added documentation

Motivation

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Aug 4, 2025
@wlgh1553
Copy link
Contributor Author

wlgh1553 commented Aug 5, 2025

This issue was cleared by this PR: #59315

@wlgh1553 wlgh1553 closed this Aug 5, 2025
@wlgh1553 wlgh1553 deleted the http-keep-alive-timeout-buffer branch August 5, 2025 05:17
@wlgh1553 wlgh1553 restored the http-keep-alive-timeout-buffer branch August 13, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants