Skip to content

build: update macOS runner and Xcode #59238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

build: update macOS runner and Xcode #59238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63ff6f
deps: V8: backport 493cb53691be
legendecas Jun 30, 2025
9acacd3
build: update macOS runner and Xcode
targos Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ concurrency:

env:
PYTHON_VERSION: '3.12'
XCODE_VERSION: '16.1'
XCODE_VERSION: '16.4'
FLAKY_TESTS: keep_retrying

permissions:
Expand All @@ -41,7 +41,7 @@ jobs:
if: github.event.pull_request.draft == false
strategy:
fail-fast: false
runs-on: macos-14
runs-on: macos-15
env:
CC: sccache gcc
CXX: sccache g++
Expand Down
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',

##### V8 defaults for Node.js #####

Expand Down
7 changes: 7 additions & 0 deletions deps/v8/include/v8-persistent-handle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,16 @@ V8_INLINE void PersistentBase<T>::SetWeak(
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-function-type"
#endif
api_internal::MakeWeak(this->slot(), parameter,
reinterpret_cast<Callback>(callback), type);
#if __clang__
#pragma clang diagnostic pop
#endif
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif
Expand Down
Loading