doc: rephrase dynamic import() description #59224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
reviewed
Jul 27, 2025
doc/api/esm.md
Outdated
| @@ -334,8 +334,13 @@ fs.readFileSync === readFileSync; | |||
|
|
|||
| ## `import()` expressions | |||
|
|
|||
| [Dynamic `import()`][] is supported in both CommonJS and ES modules. In CommonJS | |||
| modules it can be used to load ES modules. | |||
| [Dynamic `import()`][] provides a dynamic and asynchronous way to import modules, | |||
There was a problem hiding this comment.
Sould we also document that dynamic import() is dynamic?
There was a problem hiding this comment.
Thanks for the comment. I agree that the name dynamic import() is self-explanatory. I'll go ahead and remove that part to avoid redundancy.
himself65
reviewed
Jul 28, 2025
The description is updated to clarify that dynamic import() is asynchronous, dynamic, and works in both CJS and ESM contexts. The new phrasing also avoids implying it is the only method for loading ES modules in CommonJS. Fixes: nodejs#59077
|
Hi, @AugustinMauroy, I have opened a PR to address the issue you reported #59077. Your feedback and review on the changes would be greatly appreciated. Thanks! |
|
For me it's okay but let's wait what loader said |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description is updated to clarify that dynamic import() is asynchronous, dynamic, and works in both CJS and ESM contexts. The new phrasing also avoids implying it is the only method for loading ES modules in CommonJS.
Fixes: #59077