Skip to content

Conversation

codebytere
Copy link
Member

Modify a few more crypto tests to work with BoringSSL as well as OpenSSL.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (0d128e3) to head (0cd7531).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59030      +/-   ##
==========================================
- Coverage   90.08%   90.05%   -0.03%     
==========================================
  Files         645      645              
  Lines      189128   189153      +25     
  Branches    37088    37093       +5     
==========================================
- Hits       170378   170344      -34     
- Misses      11470    11530      +60     
+ Partials     7280     7279       -1     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebytere codebytere requested a review from jasnell July 17, 2025 09:19
@codebytere codebytere force-pushed the few-more-boringssl branch from 12cbfbb to 0cd7531 Compare July 17, 2025 09:22
@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2025
Copy link
Contributor

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/16355431450

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants