fix return value of fs APIs

[theanarkh]

Fixed: #58747

The C++ layer just reject the Promise but does not return the Promise to JS layer when an error occurs(Libuv error or permission error).

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[bakkot]

For testing, you can after this line the test

  assert.rejects(async () => {
    await fs.promises.mkdtemp(path.join(blockedFolder, 'any-folder'));
  }, {
    code: 'ERR_ACCESS_DENIED',
    permission: 'FileSystemWrite',
  });

That's what I had originally done when I ran into this.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (9c025a9) to head (0b4820b).
Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58996      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.03%     
==========================================
  Files         641      645       +4     
  Lines      188594   189168     +574     
  Branches    36998    37097      +99     
==========================================
+ Hits       169869   170346     +477     
- Misses      11438    11519      +81     
- Partials     7287     7303      +16     

Files with missing lines	Coverage Δ
src/node_file-inl.h	87.66% <100.00%> (+0.39%)	⬆️
src/node_file.cc	75.85% <ø> (-0.05%)	⬇️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[RafaelGSS]

PTAL @nodejs/fs

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67952/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67980/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67999/

[nodejs-github-bot]

Landed in bf2384f