Skip to content

Conversation

legendecas
Copy link
Member

Support undici sent and received data inspection in Chrome DevTools.

Support undici sent and received data inspection in Chrome DevTools.
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 4, 2025
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 87.34177% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (aad9030) to head (b766c6c).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_undici.js 88.15% 9 Missing ⚠️
lib/internal/inspector/network.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58953      +/-   ##
==========================================
+ Coverage   89.96%   90.08%   +0.11%     
==========================================
  Files         640      640              
  Lines      188454   188545      +91     
  Branches    36892    36979      +87     
==========================================
+ Hits       169546   169848     +302     
+ Misses      11608    11390     -218     
- Partials     7300     7307       +7     
Files with missing lines Coverage Δ
lib/internal/inspector/network.js 94.73% <66.66%> (+0.07%) ⬆️
lib/internal/inspector/network_undici.js 92.24% <88.15%> (-2.17%) ⬇️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit ba49d71 into nodejs:main Jul 7, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba49d71

@legendecas legendecas deleted the inspector/undici-data branch July 7, 2025 21:47
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
Support undici sent and received data inspection in Chrome DevTools.

PR-URL: #58953
Reviewed-By: Ryuhei Shima <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Jul 21, 2025

Trying to backport this to v22.x-staging causes a test failure:

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

'' !== 'foobar'

    at testRequest (…/test/parallel/test-inspector-network-fetch.js:167:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async testNetworkInspection (…/test/parallel/test-inspector-network-fetch.js:195:3)
    at async Server.<anonymous> (…/test/parallel/test-inspector-network-fetch.js:212:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '',
  expected: 'foobar',
  operator: 'strictEqual'
}

Node.js v22.17.2-pre

@aduh95 aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants