fs: close dir before throwing if options.bufferSize is invalid
#58856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58856 +/- ##
==========================================
- Coverage 90.10% 90.10% -0.01%
==========================================
Files 640 640
Lines 188493 188499 +6
Branches 36971 36968 -3
==========================================
+ Hits 169843 169848 +5
- Misses 11358 11361 +3
+ Partials 7292 7290 -2
🚀 New features to boost your workflow:
|
LiviaMedeiros
force-pushed
the
fs-dir-close-on-invalid-buffer
branch
from
2155c48 to
67ea569
Compare
LiviaMedeiros
force-pushed
the
fs-dir-close-on-invalid-buffer
branch
from
67ea569 to
eadbae5
Compare
lpinca
approved these changes
Jul 5, 2025
jasnell
approved these changes
Jul 5, 2025
juanarbol
approved these changes
Jul 6, 2025
juanarbol
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9ab9763 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
PR-URL: #58856 Fixes: #58854 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58856 Fixes: #58854 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58856 Fixes: #58854 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58854
Test blocked on: #58855