-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
[v22.x backport] esm: implement import.meta.main #58693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x backport] esm: implement import.meta.main #58693
Conversation
Review requested:
|
Should include #58661 if it doesn't already |
We should only pick the commits that have landed on |
Ah, my bad, I probably picked commits from the wrong branch. |
e529a26
to
8868f38
Compare
@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK? |
What's the deal here? I don't understand why CI is failing 🤔 |
You can use
It looks like the Coverage CI is broken on that branch, unrelated to your changes. The macOS one timed out, also probably unrelated to your changes. |
can you include bba07d7 in the backport (if lands cleanly otherwise I can open a backport) |
Sorry I didnt notice it was already included. Looks good |
25ba866
to
ea7c98b
Compare
FWIW the broken Coverage Windows GitHub Workflow is the same breakage as #58801 (and unrelated to this PR). cc FYI @nodejs/releasers |
ea7c98b
to
d546c7a
Compare
Rebased onto |
Can you please rebase? |
d546c7a
to
917555b
Compare
Something weird happened and I had to drop a couple of commits, then redo the rebase - let me know whether or not things look OK |
686d42a
to
ee7910e
Compare
Rebased on top of |
Boolean value to check if an ES Module is the entrypoint of the current process. Implements: nodejs#57226 Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#57804 Backport-PR-URL: nodejs#58693 Fixes: nodejs#57226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#58661 Backport-PR-URL: nodejs#58693 Fixes: nodejs#58660 Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
ee7910e
to
2fc8989
Compare
Landed in f99aa74...2fc8989 |
Backport #57804 and #58661 to v22.x release line