Skip to content

[v24.x] Backport doc deprecations #58542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v24.x] Backport doc deprecations #58542

wants to merge 2 commits into from
+66 −3

Conversation

targos
Copy link
Member

@targos targos commented Jun 1, 2025

Includes:

mcollina and others added 2 commits June 1, 2025 09:10
@mcollina @aduh95 @targos
doc: deprecate HTTP/2 priority signaling
6cc1d52 
Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#58313
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
@aduh95 @targos
doc: clarify DEP0194 scope
0dedb57 
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: nodejs#58504
Refs: nodejs#58313
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Jun 1, 2025
@targos targos mentioned this pull request Jun 1, 2025
Merged
mcollina
mcollina approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardlau richardlau added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 1, 2025
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jun 3, 2025
targos pushed a commit that referenced this pull request Jun 3, 2025
@mcollina @aduh95 @targos
doc: deprecate HTTP/2 priority signaling
af0446e 
Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #58313
Backport-PR-URL: #58542
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
targos pushed a commit that referenced this pull request Jun 3, 2025
@aduh95 @targos
doc: clarify DEP0194 scope
2f555e0 
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: #58504
Backport-PR-URL: #58542
Refs: #58313
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos
Copy link
Member Author

targos commented Jun 3, 2025

Landed in 8a1eaea...2f555e0

@targos targos closed this Jun 3, 2025
@targos targos deleted the backport-deprecation-v24 branch June 3, 2025 08:02
aduh95 added a commit that referenced this pull request Jun 10, 2025
@mcollina @aduh95
doc: deprecate HTTP/2 priority signaling
1e6d7da 
Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #58313
Backport-PR-URL: #58542
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
aduh95 added a commit that referenced this pull request Jun 10, 2025
@aduh95
doc: clarify DEP0194 scope
7d0df64 
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: #58504
Backport-PR-URL: #58542
Refs: #58313
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
backported-to-v22.x PRs backported to the v22.x-staging branch. doc Issues and PRs related to the documentations. lts-watch-v20.x PRs that may need to be released in v20.x v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @mcollina @richardlau @RafaelGSS @marco-ippolito @bjohansebas @aduh95