Add SourceMap Benchmark #58125

miguelmarcondesf · 2025-05-02T17:48:50Z

Add SourceMap Benchmark

This PR introduces a new benchmark suite for the lib/internal/source_map module to help evaluate and explore the performance characteristics of the SourceMap.

I'm still learning how everything fits together, but this is a first step toward understanding where small improvements could improve performance.

cc @BridgeAR

nodejs-github-bot · 2025-05-02T17:48:55Z

Review requested:

@nodejs/performance
@nodejs/tsc

miguelmarcondesf · 2025-05-03T21:12:47Z

Local running with n: 1e5 for all cases:

anonrig · 2025-05-03T22:43:13Z

You need to add a test for these benchmarks. You can find similar ones in test folder.

miguelmarcondesf · 2025-05-04T10:41:09Z

You need to add a test for these benchmarks. You can find similar ones in test folder.

Thank you, just pushed that!

codecov · 2025-05-06T17:32:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (04cb572) to head (c071304).
Report is 93 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58125      +/-   ##
==========================================
+ Coverage   90.07%   90.09%   +0.02%     
==========================================
  Files         640      640              
  Lines      188262   188262              
  Branches    36912    36911       -1     
==========================================
+ Hits       169580   169623      +43     
+ Misses      11399    11363      -36     
+ Partials     7283     7276       -7

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benchmark/es/error-stack.js

doc/contributing/writing-and-running-benchmarks.md

benchmark/source_map/source-map.js

benchmark/source_map/prepare-stack-trace.js

benchmark/source_map/source-map.js

benchmark/source_map/source-map-cache.js

benchmark/source_map/source-map.js

benchmark/source_map/prepare-stack-trace.js

benchmark/source_map/source-map-cache.js

legendecas

Thank you for the change! Overall LGTM % nits.

benchmark/source_map/source-map-cache.js

benchmark/source_map/source-map.js

benchmark/source_map/source-map-cache.js

nodejs-github-bot · 2025-06-20T13:24:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67569/

nodejs-github-bot · 2025-07-01T12:56:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/58125
✔  Done loading data for nodejs/node/pull/58125
----------------------------------- PR info ------------------------------------
Title      Add SourceMap Benchmark (#58125)
Author     Miguel Marcondes Filho <[email protected]> (@miguelmarcondesf)
Branch     miguelmarcondesf:performance-improvements-sourcemap -> nodejs:main
Labels     author ready, needs-ci, commit-queue-squash
Commits    3
 - benchmark: add source map and source map cache
 - benchmark: use fixtures for sourcemap cache
 - benchmark: use fixtures and avoid dead code for sourcemap
Committers 1
 - Miguel Marcondes <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58125
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58125
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 02 May 2025 17:48:50 GMT
   ✔  Approvals: 4
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2946108239
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/58125#pullrequestreview-2950130654
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2952013937
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2975274650
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-06-23T13:44:33Z: https://ci.nodejs.org/job/node-test-pull-request/67620/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - benchmark: add source map and source map cache
   ⚠  - benchmark: use fixtures for sourcemap cache
   ⚠  - benchmark: use fixtures and avoid dead code for sourcemap
- Querying data for job/node-test-pull-request/67620/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/15999945215

nodejs-github-bot · 2025-07-07T10:23:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67863/

nodejs-github-bot · 2025-07-07T14:04:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67870/

nodejs-github-bot · 2025-07-07T15:53:37Z

Landed in 9c025a9

PR-URL: #58125 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 2, 2025

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch from 5e438af to 4147ff3 Compare May 2, 2025 20:07

miguelmarcondesf changed the title ~~Performance improvements sourcemap~~ Add SourceMap Benchmark May 2, 2025

miguelmarcondesf marked this pull request as ready for review May 3, 2025 21:12

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch from 5749fce to bc9fbe9 Compare May 6, 2025 16:42

geeksilva97 requested a review from H4ad May 20, 2025 14:16

legendecas requested changes Jun 2, 2025

View reviewed changes

benchmark/es/error-stack.js Outdated Show resolved Hide resolved

doc/contributing/writing-and-running-benchmarks.md Outdated Show resolved Hide resolved

benchmark/source_map/source-map.js Outdated Show resolved Hide resolved

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch 2 times, most recently from f1040cd to 421ae12 Compare June 5, 2025 18:55

miguelmarcondesf requested a review from legendecas June 6, 2025 11:41

legendecas reviewed Jun 6, 2025

View reviewed changes

miguelmarcondesf commented Jun 6, 2025

View reviewed changes

benchmark/source_map/prepare-stack-trace.js Outdated Show resolved Hide resolved

miguelmarcondesf requested a review from legendecas June 9, 2025 16:41

legendecas reviewed Jun 9, 2025

View reviewed changes

benchmark/source_map/source-map-cache.js Outdated Show resolved Hide resolved

benchmark/source_map/source-map-cache.js Outdated Show resolved Hide resolved

benchmark/source_map/source-map-cache.js Outdated Show resolved Hide resolved

miguelmarcondesf requested a review from legendecas June 18, 2025 15:56

legendecas reviewed Jun 18, 2025

View reviewed changes

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch from 02b5acc to 7eab302 Compare June 18, 2025 23:50

legendecas reviewed Jun 19, 2025

View reviewed changes

benchmark/source_map/source-map-cache.js Outdated Show resolved Hide resolved

miguelmarcondesf requested a review from legendecas June 20, 2025 12:56

legendecas approved these changes Jun 20, 2025

View reviewed changes

legendecas added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 20, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2025

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch from c7232d1 to ac7a40e Compare June 20, 2025 20:30

miguelmarcondesf added 3 commits June 23, 2025 15:57

benchmark: add source map and source map cache

d6f5227

benchmark: use fixtures for sourcemap cache

efa9c71

benchmark: use fixtures and avoid dead code for sourcemap

c071304

miguelmarcondesf force-pushed the performance-improvements-sourcemap branch from ac7a40e to c071304 Compare June 23, 2025 20:37

jasnell approved these changes Jun 24, 2025

View reviewed changes

miguelmarcondesf requested a review from RafaelGSS June 25, 2025 09:11

RafaelGSS approved these changes Jul 1, 2025

View reviewed changes

RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 1, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 1, 2025

geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 1, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2025

This comment was marked as outdated.

Sign in to view

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

This comment was marked as outdated.

Sign in to view

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025

This comment was marked as outdated.

Sign in to view

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025

nodejs-github-bot merged commit 9c025a9 into nodejs:main Jul 7, 2025
80 checks passed

github-actions bot mentioned this pull request Jul 8, 2025

2025-07-09, Version 24.4.0 (Current) #58993

Merged

Uh oh!

Add SourceMap Benchmark #58125

Add SourceMap Benchmark #58125

Uh oh!

Conversation

miguelmarcondesf commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!