crypto: support outputLength option in crypto.hash for XOF functions #58121

Aditi-1400 · 2025-05-02T14:25:04Z

Support outputLength option in crypto.hash() for XOF hash functions to align with the behaviour of crypto.createHash() API

Fixes: #57312

nodejs-github-bot · 2025-05-02T14:25:09Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

deps/ncrypto/ncrypto.cc

panva

@Aditi-1400 please change the PR title and commit message to crypto: support outputLength in crypto.hash for XOF functions

codecov · 2025-05-02T15:45:22Z

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (f5da8f8) to head (a27fe2b).
Report is 68 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_hash.cc	73.33%	9 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58121      +/-   ##
==========================================
- Coverage   90.08%   90.08%   -0.01%     
==========================================
  Files         640      640              
  Lines      188517   188569      +52     
  Branches    36975    36995      +20     
==========================================
+ Hits       169826   169868      +42     
- Misses      11402    11418      +16     
+ Partials     7289     7283       -6

Files with missing lines	Coverage Δ
lib/internal/crypto/hash.js	`98.53% <100.00%> (+0.09%)`	⬆️
src/crypto/crypto_hash.cc	`70.35% <73.33%> (-0.21%)`	⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell · 2025-05-06T23:49:17Z

deps/ncrypto/ncrypto.cc

+DataPointer xofHashDigest(const Buffer<const unsigned char>& buf,
+                          const EVP_MD* md,
+                          size_t output_length) {
+  if (md == nullptr) return {};


@codebytere ... can I ask you to take a look at this from a Whether-This-Will-Work-In-BoringSSL perspective?

deps/ncrypto/ncrypto.cc

deps/ncrypto/ncrypto.h

doc/api/crypto.md

src/crypto/crypto_hash.cc

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

doc/api/crypto.md

deps/ncrypto/ncrypto.cc

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

nodejs-github-bot · 2025-07-05T10:35:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67846/

nodejs-github-bot · 2025-07-05T11:33:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67847/

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121 PR-URL: nodejs#58942 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

joyeecheung

LGTM % the doc nit

joyeecheung · 2025-07-08T13:16:09Z

Needs a new CI after the push

panva · 2025-07-08T13:19:10Z

@joyeecheung CI has ran with the latest push.

nodejs-github-bot · 2025-07-08T13:39:02Z

Landed in 1c4fe6d

Reverts: #56160 Fixes: #56159 Fixes: #58913 Refs: #58121 PR-URL: #58942 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Support `outputLength` option in crypto.hash() for XOF hash functions to align with the behaviour of crypto.createHash() API closes: #57312 Co-authored-by: Filip Skokan <[email protected]> PR-URL: #58121 Fixes: #57312 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121 PR-URL: nodejs#58942 Backport-PR-URL: nodejs#58960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

aduh95 · 2025-07-21T18:40:00Z

This doesn't land cleanly on v22.x-staging

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 2, 2025

panva requested review from tniessen and joyeecheung May 2, 2025 14:26

panva added the crypto Issues and PRs related to the crypto subsystem. label May 2, 2025

joyeecheung reviewed May 2, 2025

View reviewed changes

deps/ncrypto/ncrypto.cc Show resolved Hide resolved

panva reviewed May 2, 2025

View reviewed changes

Aditi-1400 changed the title ~~src: support outputLength in XOF hash functions~~ crypto: support outputLength in XOF hash functions May 2, 2025

jasnell reviewed May 6, 2025

View reviewed changes

deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved

jasnell reviewed May 6, 2025

View reviewed changes

deps/ncrypto/ncrypto.h Show resolved Hide resolved

jasnell reviewed May 6, 2025

View reviewed changes

doc/api/crypto.md Outdated Show resolved Hide resolved

Aditi-1400 force-pushed the crypto-hash branch from d0594f4 to aeab00b Compare May 12, 2025 17:12

Aditi-1400 force-pushed the crypto-hash branch from aeab00b to f40c837 Compare May 27, 2025 12:50

joyeecheung reviewed May 28, 2025

View reviewed changes

src/crypto/crypto_hash.cc Outdated Show resolved Hide resolved

Aditi-1400 force-pushed the crypto-hash branch from f40c837 to b9379c5 Compare May 28, 2025 21:07

panva mentioned this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58942

Merged

panva added a commit to panva/node that referenced this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

32a9526

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

joyeecheung approved these changes Jul 3, 2025

View reviewed changes

doc/api/crypto.md Show resolved Hide resolved

Aditi-1400 force-pushed the crypto-hash branch from b9379c5 to c44c09e Compare July 3, 2025 12:37

joyeecheung reviewed Jul 3, 2025

View reviewed changes

deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved

panva added a commit to panva/node that referenced this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

aaca3a1

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

panva added a commit to panva/node that referenced this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

eccf285

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

panva added a commit to panva/node that referenced this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

30cfc50

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

panva added a commit to panva/node that referenced this pull request Jul 3, 2025

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

d870b4f

Reverts: nodejs#56160 Fixes: nodejs#56159 Fixes: nodejs#58913 Refs: nodejs#58121

Aditi-1400 force-pushed the crypto-hash branch 3 times, most recently from beb4f68 to 068c2ce Compare July 3, 2025 17:26

panva requested review from joyeecheung and jasnell July 5, 2025 10:36

panva added the review wanted PRs that need reviews. label Jul 8, 2025

joyeecheung approved these changes Jul 8, 2025

View reviewed changes

panva approved these changes Jul 8, 2025

View reviewed changes

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2025

RafaelGSS approved these changes Jul 8, 2025

View reviewed changes

joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 8, 2025

panva removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2025

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2025

nodejs-github-bot merged commit 1c4fe6d into nodejs:main Jul 8, 2025
68 checks passed

github-actions bot mentioned this pull request Jul 8, 2025

2025-07-09, Version 24.4.0 (Current) #58993

Merged

Renegade334 mentioned this pull request Jul 14, 2025

Node 24.4.0 OOMs with pnpm #59057

Closed

aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Jul 21, 2025

This comment was marked as off-topic.

Sign in to view

Uh oh!

crypto: support outputLength option in crypto.hash for XOF functions #58121

crypto: support outputLength option in crypto.hash for XOF functions #58121

Uh oh!

Conversation

Aditi-1400 commented May 2, 2025

Uh oh!

nodejs-github-bot commented May 2, 2025

Uh oh!

Uh oh!

panva left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jasnell May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 5, 2025

Uh oh!

nodejs-github-bot commented Jul 5, 2025

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jul 8, 2025

Uh oh!

panva commented Jul 8, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 8, 2025

Uh oh!

aduh95 commented Jul 21, 2025

Uh oh!

This comment was marked as off-topic.

Uh oh!

codecov bot commented May 2, 2025 •

edited

Loading