Skip to content

Conversation

Renegade334
Copy link
Contributor

I have a box named "io". This got a good chuckle out of me.

=== release test-runner-output ===                                            
Path: parallel/test-runner-output
Test failure: 'test-runner/output/junit_reporter.js'
Location: test/parallel/test-runner-output.mjs:330:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
... Skipped lines

+ '<?xml versHOSTNAMEn="1.0" encoding="utf-8"?>\n' +
- '<?xml version="1.0" encoding="utf-8"?>\n' +
    '<testsuites>\n' +
    '\t<testcase name="sync pass todo" time="*" classname="test">\n' +
    '\t\t<skipped type="todo" message="true"/>\n' +
    '\t</testcase>\n' +
    '\t<testcase name="sync pass todo with message" time="*" classname="test">\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="async assertHOSTNAMEn fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
-   '\t<testcase name="async assertion fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
    '\t\t<failure type="testCodeFailure" message="Expected values to be strictly equal:true !== false">\n' +
    '[Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:\n' +
    '\n' +
    'true !== false\n' +
    '] {\n' +
    "  code: 'ERR_TEST_FAILURE',\n" +
    "  failureType: 'testCodeFailure',\n" +
+   '  cause: AssertHOSTNAMEnError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
-   '  cause: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
    '  \n' +
    '  true !== false\n' +
    '  \n' +
    '      *\n' +
    '      *\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
+   '\t<testcase name="async unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="async unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
    ...,
  operator: 'strictEqual'
}

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (53abd1a) to head (ca3e005).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58076      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         630      630              
  Lines      186391   186391              
  Branches    36612    36611       -1     
==========================================
- Hits       168134   168127       -7     
+ Misses      11068    11062       -6     
- Partials     7189     7202      +13     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@pmarchini pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2b4f554 into nodejs:main May 1, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2b4f554

RafaelGSS pushed a commit that referenced this pull request May 2, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@Renegade334 Renegade334 deleted the test-runner-output-hostname branch May 31, 2025 19:01
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
PR-URL: #58076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants