Skip to content

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 12, 2025

Disable a clang warning caused by #54990:

../../node/src/node_options.cc:60:20: error: loop variable 'entry' binds to a temporary value produced by a range of type 'decltype(split_view<views::all_t<string &>, views::all_t<string_view>>(std::forward<std::string &>(__range), std::forward<std::string_view>(__pattern)))' (aka 'split_view<ref_view<std::string>, std::string_view>') [-Werror,-Wrange-loop-bind-reference]
   60 |   for (const auto& entry : entries) {
      |                    ^
../../node/src/node_options.cc:60:8: note: use non-reference type 'value_type' (aka 'subrange<std::__wrap_iter<char *>>')
   60 |   for (const auto& entry : entries) {
      |        ^~~~~~~~~~~~~~~~~~~

According to discussions at https://huixie90.github.io/wrange-loop-analysis/, I think the code is totally valid and we should not modify code to work around the warning.

Also fix zstd dep.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 12, 2025
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@zcbenz zcbenz added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2025
@nodejs-github-bot nodejs-github-bot merged commit 44e2671 into nodejs:main Feb 15, 2025
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 44e2671

targos pushed a commit that referenced this pull request Feb 17, 2025
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
codebytere added a commit to electron/electron that referenced this pull request May 1, 2025
codebytere added a commit to electron/electron that referenced this pull request May 5, 2025
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* src: lock the isolate properly in IsolateData destructor

nodejs/node#57031

* chore: shrink --trace-atomics-wait patch

* chore: fixup patch indices

* build: fix GN build failure

nodejs/node#57013

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* cli: move --trace-atomics-wait to eol

nodejs/node#52747

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request May 5, 2025
codebytere added a commit to electron/electron that referenced this pull request May 6, 2025
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* src: lock the isolate properly in IsolateData destructor

nodejs/node#57031

* chore: shrink --trace-atomics-wait patch

* chore: fixup patch indices

* build: fix GN build failure

nodejs/node#57013

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* cli: move --trace-atomics-wait to eol

nodejs/node#52747

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants