Skip to content

events: fix undefined passes to arrayClone #56264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

events: fix undefined passes to arrayClone #56264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e227da7
events: fix undefined passes to arrayClone
origranot Dec 15, 2024
8e61347
test: add a test case
origranot Dec 15, 2024
6b93137
fix: linting issue
origranot Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,8 @@ function _listeners(target, type, unwrap) {
return [];

const evlistener = target._events[type];
if (evlistener === undefined)
return [];

if (typeof evlistener === 'function')
return unwrap ? [evlistener.listener || evlistener] : [evlistener];
Expand Down
5 changes: 5 additions & 0 deletions test/parallel/test-event-emitter-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ function listener4() {
assert.deepStrictEqual(ee.listeners('foo'), []);
}

{
const ee = new events.EventEmitter();
assert.deepStrictEqual(ee.listeners(), []);
}

{
class TestStream extends events.EventEmitter {}
const s = new TestStream();
Expand Down
Loading