-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
fs,win: fix readdir for named pipe #56110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
JaneaSystems:huseyin-12718-readdir-named-pipe
Dec 10, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
54534dd
fs,win: fix readdir for named pipe
huseyinacacak-janea ee8ac15
fixup! fs,win: fix readdir for named pipe
huseyinacacak-janea 66ca939
Update test/parallel/test-fs-readdir-pipe.js
huseyinacacak-janea 572569c
Update test/parallel/test-fs-readdir-pipe.js
huseyinacacak-janea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const { readdir, readdirSync } = require('fs'); | ||
|
||
if (!common.isWindows) { | ||
common.skip('This test is specific to Windows to test enumerate pipes'); | ||
} | ||
|
||
// Ref: https://github.com/nodejs/node/issues/56002 | ||
// This test is specific to Windows. | ||
|
||
const pipe = '\\\\.\\pipe\\'; | ||
|
||
const { length } = readdirSync(pipe); | ||
assert.ok(length >= 0, `${length} is not greater or equal to 0`); | ||
|
||
readdir(pipe, common.mustSucceed((files) => { | ||
assert.ok(files.length >= 0, `${files.length} is not greater or equal to 0`); | ||
})); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.