-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
test: move more zlib tests to node:test #54609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/zlib-tests-node-test
Sep 1, 2024
Merged
test: move more zlib tests to node:test #54609
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/zlib-tests-node-test
Sep 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54609 +/- ##
==========================================
- Coverage 87.34% 87.30% -0.04%
==========================================
Files 649 649
Lines 182562 182755 +193
Branches 35023 35044 +21
==========================================
+ Hits 159451 159561 +110
- Misses 16396 16465 +69
- Partials 6715 6729 +14 |
c1b0693
to
7631e70
Compare
atlowChemi
reviewed
Aug 29, 2024
atlowChemi
reviewed
Aug 29, 2024
bdd2e1e
to
749198f
Compare
749198f
to
abf4dcc
Compare
abf4dcc
to
af7fd9a
Compare
jasnell
approved these changes
Aug 29, 2024
atlowChemi
approved these changes
Aug 29, 2024
Landed in 826b753 |
sendoru
pushed a commit
to sendoru/node
that referenced
this pull request
Sep 1, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54609 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54609 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
zlib
Issues and PRs related to the zlib subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving zlib tests to use
node:test