url: improve invalid url performance #49692

anonrig · 2023-09-17T21:19:37Z

Some easy wins for Invalid URL path.

                                                    confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-validity.js e=100000 type='invalid'        ***    120.33 %       ±2.06% ±2.74% ±3.56%
url/whatwg-url-validity.js e=100000 type='valid'                   1.35 %       ±2.21% ±2.96% ±3.91%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

cc @nodejs/url @nodejs/performance

nodejs-github-bot · 2023-09-17T21:19:41Z

Review requested:

@nodejs/url

anonrig · 2023-09-17T21:38:58Z

@nodejs/tsc I've removed the error.input from URL error - ERR_INVALID_URL to make sure we share a similar output with Chrome and Safari. I've also added semver-major label because of the removal of error.input attribute.

Safari returns: TypeError: Type error
Chrome returns: VM78:1 Uncaught TypeError: Failed to construct 'URL': Invalid URL

None of them have the error.input attribute.

aduh95 · 2023-09-17T21:42:58Z

I would keep the input, and even add the base, it can very hard to understand what is the error without seeing the input and base

lib/internal/errors.js

rluvaton · 2023-09-18T06:33:43Z

Benchmark CI:
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1396/

mcollina

lgtm

aduh95 · 2023-09-18T10:23:28Z

Could there be a way to get the same performance improvements without removing helpful debugging information? If not, maybe we could use a flag to opt-in to the slower option that outputs the input and base?

anonrig · 2023-09-18T14:40:43Z

Could there be a way to get the same performance improvements without removing helpful debugging information? If not, maybe we could use a flag to opt-in to the slower option that outputs the input and base?

Probably, although I'm not sure. This requires a similar approach to what ThrowAccessDenied is doing in https://github.com/nodejs/node/blob/main/src/permission/permission.cc#L102.

nodejs-github-bot · 2023-09-18T19:51:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54043/

nodejs-github-bot · 2023-09-18T22:09:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54047/

tniessen · 2023-09-19T08:55:11Z

FWIW, I tend to agree with @aduh95 that removing error information for the sake of performance (on an error path!) does not benefit users. I thought that URL.canParse() was specifically added to avoid having to rely on the performance of the URL error path.

Uzlopak · 2023-09-19T09:20:43Z

How much is actually the performance hit when keeping the input as an attribute?

BridgeAR

I do not think it's a good idea to remove important debug information in favor of performance. We can definitely improve the performance but debug information is more important. I had an open PR to improve the situation a lot and I have to get back to that again.

anonrig · 2023-09-19T22:31:35Z

@BridgeAR @aduh95 @tniessen I've updated the implementation. Previously this pull request was 142% faster than main. Right now it is 120% faster. I also added base field to the error object.

Appreciate it, if you can review it once again.

nodejs-github-bot · 2023-09-20T03:24:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54072/

nodejs-github-bot · 2023-09-20T15:03:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54088/

nodejs-github-bot · 2023-09-20T23:33:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54099/

nodejs-github-bot · 2023-09-21T16:19:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54128/

anonrig · 2023-09-22T18:24:20Z

Hey @BridgeAR, can you re-review this pull request, and remove your block?

benjamingr · 2023-09-23T13:08:35Z

I suspect he would still object since the URL isn't part of the message string, what's the cost of adding that back?

anonrig · 2023-09-23T13:58:32Z

I suspect he would still object since the URL isn't part of the message string, what's the cost of adding that back?

I don't follow. URL was never part of the message string? Input is a property of the error object. On top of that I've also added base property to the error as well.

benjamingr · 2023-09-23T14:29:42Z

@anonrig ah, I'm probably mixing it up with another PR then, lgtm

anonrig · 2023-09-26T15:18:37Z

Adding to @nodejs/tsc agenda to resolve the block.

targos · 2023-09-26T15:28:25Z

There's no need for the TSC to intervene if you addressed the blocking comment

The comment is addressed.

nodejs-github-bot · 2023-09-26T15:40:19Z

Landed in c829c03

PR-URL: #49692 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#49692 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

anonrig added performance Issues and PRs related to the performance of Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 17, 2023

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 17, 2023

anonrig force-pushed the improve-invalid-url-performance branch from 0501c68 to 79415ed Compare September 17, 2023 21:36

anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 17, 2023

Uzlopak reviewed Sep 17, 2023

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

rluvaton added the needs-benchmark-ci PR that need a benchmark CI run. label Sep 18, 2023

mcollina approved these changes Sep 18, 2023

View reviewed changes

ronag approved these changes Sep 18, 2023

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023

BridgeAR previously requested changes Sep 19, 2023

View reviewed changes

anonrig force-pushed the improve-invalid-url-performance branch from 147dd75 to a9c408a Compare September 19, 2023 22:30

anonrig force-pushed the improve-invalid-url-performance branch from a9c408a to 29267d9 Compare September 19, 2023 22:32

anonrig requested a review from BridgeAR September 19, 2023 22:33

url: improve invalid url performance

c59b136

anonrig force-pushed the improve-invalid-url-performance branch from 29267d9 to c59b136 Compare September 19, 2023 22:38

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023

anonrig removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023

github-actions bot mentioned this pull request Sep 21, 2023

CI Reliability 2023-09-21 nodejs/reliability#672

Open

22 tasks

github-actions bot mentioned this pull request Sep 22, 2023

CI Reliability 2023-09-22 nodejs/reliability#673

Open

17 tasks

github-actions bot mentioned this pull request Sep 23, 2023

CI Reliability 2023-09-23 nodejs/reliability#674

Open

16 tasks

benjamingr approved these changes Sep 23, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 24, 2023

CI Reliability 2023-09-24 nodejs/reliability#675

Open

20 tasks

anonrig added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 26, 2023

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Sep 26, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2023

nodejs-github-bot merged commit c829c03 into nodejs:main Sep 26, 2023

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023

url: improve invalid url performance

7d91a73

PR-URL: #49692 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno mentioned this pull request Sep 28, 2023

v20.7.1 proposal #49917

Closed

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023

url: improve invalid url performance

097b598

PR-URL: #49692 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno mentioned this pull request Sep 28, 2023

v20.8.0 proposal #49932

Merged

Uh oh!

url: improve invalid url performance #49692

url: improve invalid url performance #49692

Uh oh!

Conversation

anonrig commented Sep 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

anonrig commented Sep 17, 2023

Uh oh!

aduh95 commented Sep 17, 2023

Uh oh!

Uh oh!

rluvaton commented Sep 18, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Sep 18, 2023

Uh oh!

anonrig commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

tniessen commented Sep 19, 2023

Uh oh!

Uzlopak commented Sep 19, 2023

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

anonrig commented Sep 19, 2023

Uh oh!

nodejs-github-bot commented Sep 20, 2023

Uh oh!

nodejs-github-bot commented Sep 20, 2023

Uh oh!

nodejs-github-bot commented Sep 20, 2023

Uh oh!

nodejs-github-bot commented Sep 21, 2023

Uh oh!

anonrig commented Sep 22, 2023

Uh oh!

benjamingr commented Sep 23, 2023

Uh oh!

anonrig commented Sep 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented Sep 23, 2023

Uh oh!

anonrig commented Sep 26, 2023

Uh oh!

targos commented Sep 26, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

Uh oh!

anonrig commented Sep 17, 2023 •

edited

Loading

anonrig commented Sep 23, 2023 •

edited

Loading