Skip to content

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Sep 12, 2023

also added more webstream creation benchmarks

PR-URL: #49546
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Matteo Collina [email protected]

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels Sep 12, 2023
@rluvaton rluvaton changed the title stream: improve tee perf by reduce ReflectConstruct usages [v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages Sep 12, 2023
@rluvaton rluvaton mentioned this pull request Sep 12, 2023
also added more webstream creation benchmarks

PR-URL: nodejs#49546
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@rluvaton rluvaton force-pushed the backport-49546-to-v20.x branch from 8eb0194 to 3f7b05e Compare September 12, 2023 13:41
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

UlisesGascon pushed a commit that referenced this pull request Sep 13, 2023
also added more webstream creation benchmarks

PR-URL: #49546
Backport-PR-URL: #49620
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@UlisesGascon
Copy link
Member

Landed in 8aac95d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants