lib: improve performance of readable webstreams #46080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
anonrig
added
performance
github-actions
bot
removed
the
request-ci
|
Streams benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1288/ |
|
Looks like this test fails https://github.com/nodejs/node/blob/master/test/parallel/test-stream-uint8array.js#L1-L102 Probably need to do something more specific than checking |
|
The title says webstreams, but you are touching node.js streams. Could you please clarify? |
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't verify this with the existing
webstreamsbenchmarks. Opening in case somebody points me to the exact benchmark and/or provides one.Referencing: oven-sh/bun#1708