Skip to content

Conversation

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Dec 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@ruyadorno ruyadorno added fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. and removed fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. dont-land-on-v14.x labels Dec 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2022
@ruyadorno

This comment was marked as resolved.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

@ruyadorno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

Is it working again @richardlau ?

@richardlau
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/48682/

Node.js 14 CI is currently broken: nodejs/build#3131

Is it working again @richardlau ?

Unfortunately not. Nobody looked at the failures while I was out and I've only been able to fix the macOS 10.14 builds since I've been back at work.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@nodejs-github-bot

This comment was marked as outdated.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau removed the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2023
richardlau pushed a commit that referenced this pull request Feb 8, 2023
PR-URL: #45936
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau
Copy link
Member

Landed in 224e93c.

@richardlau richardlau closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants