[v16.x backport] readline: add Promise-based API

.eslintrc.js

@@ -163,7 +163,7 @@ module.exports = {
     'keyword-spacing': 'error',
     'linebreak-style': ['error', 'unix'],
     'max-len': ['error', {
-      code: 80,
+      code: 120,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
       ignoreTemplateLiterals: true,
@@ -186,7 +186,6 @@ module.exports = {
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
-    /* eslint-disable max-len */
     'no-restricted-properties': [
       'error',
       {
@@ -239,7 +238,6 @@ module.exports = {
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
     ],
-    /* eslint-enable max-len */
     'no-return-await': 'error',
     'no-self-compare': 'error',
     'no-tabs': 'error',
@@ -297,10 +295,7 @@ module.exports = {
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
     // ESLint recommended rules that we disable
-    'no-cond-assign': 'off',
-    'no-empty': 'off',
     'no-inner-declarations': 'off',
-    'no-prototype-builtins': 'off',
 
     // JSDoc recommended rules that we disable
     'jsdoc/require-jsdoc': 'off',

.github/CODEOWNERS

@@ -13,9 +13,7 @@
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
 /LICENSE @nodejs/tsc
-/doc/guides/contributing/*.md @nodejs/tsc
-/doc/guides/collaborator-guide.md @nodejs/tsc
-/doc/guides/offboarding.md @nodejs/tsc
+/doc/contributing/*.md @nodejs/tsc
 
 # streams
 
@@ -88,7 +86,7 @@
 
 /src/node_api* @nodejs/node-api
 /src/js_native_api* @nodejs/node-api
-/doc/guides/adding-new-napi-api.md @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
 /doc/api/n-api.md @nodejs/node-api
 
 # gyp

.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -8,6 +8,9 @@ body:
         Thank you for suggesting an idea to make Node.js better.
 
         Please fill in as much of the following form as you're able.
+
+        For more information on how the project manages feature
+        requests, see [Feature request management](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).
   - type: textarea
     attributes:
       label: What is the problem this feature will solve?

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,7 @@ Before submitting a pull request, please read
 https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
 
 Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines
+https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.

.github/workflows/auto-start-ci.yml

@@ -5,7 +5,7 @@ on:
     # Runs every five minutes (fastest the scheduler can run). Five minutes is
     # optimistic, it can take longer to run.
     # To understand why `schedule` is used instead of other events, refer to
-    # ./doc/guides/commit-queue.md
+    # ./doc/contributing/commit-queue.md
     - cron: "*/5 * * * *"
 
 env:

.github/workflows/build-windows.yml

@@ -26,11 +26,7 @@ env:
 jobs:
   build-windows:
     if: github.event.pull_request.draft == false
-    strategy:
-      matrix:
-        windows: [windows-2019, windows-2022]
-      fail-fast: false
-    runs-on: ${{ matrix.windows }}
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/coverage-windows.yml

@@ -31,7 +31,7 @@ env:
 jobs:
   coverage-windows:
     if: github.event.pull_request.draft == false
-    runs-on: windows-latest
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v2
         with:

.gitignore

@@ -159,3 +159,6 @@ install_manifest.txt
 __pycache__
 .DS_Store
 *~
+
+# === Rules for C++ development ===
+compile_commands.json

.mailmap

@@ -4,6 +4,8 @@ Aaron Heckmann <[email protected]> <[email protected]>
 Aayush Ahuja <[email protected]>
 Abe Fettig <[email protected]> <[email protected]>
 Abhimanyu Vashisht <[email protected]>
+Akhil Marsonya <[email protected]>
+Akhil Marsonya <[email protected]> <[email protected]>
 Akito Ito <[email protected]> <[email protected]>
 Alejandro Estrada <[email protected]>
 Alejandro Estrada <[email protected]> <[email protected]>
@@ -112,6 +114,7 @@ Daniel Paulino <[email protected]>
 Daniel Pihlström <[email protected]>
 Daniel Wang <[email protected]>
 Daniel Wang <[email protected]> <[email protected]>
+Danielle Adams <[email protected]> <[email protected]>
 Danielle Adams <[email protected]> <[email protected]>
 Danny Guo <[email protected]> <[email protected]>
 Danny Nemer <[email protected]> <[email protected]>
@@ -231,6 +234,8 @@ Jerry Chin <[email protected]>
 Jessica Quynh Tran <[email protected]>
 Jesús Leganés-Combarro 'piranna <[email protected]>
 Jimb Esser <[email protected]> <[email protected]>
+Jithil P Ponnan <[email protected]>
+Jithil P Ponnan <[email protected]> <[email protected]>
 Jochen Eisinger <[email protected]> 
 Joe Shaw <[email protected]> <[email protected]>
 Johan Bergström <[email protected]>
@@ -323,6 +328,7 @@ Matthew Turner <[email protected]> <[email protected]>
 Matthias Bastian <[email protected]> <[email protected]>
 Maurice Hayward <[email protected]>
 Maya Lekova <[email protected]> <[email protected]>
+Mestery <[email protected]> <[email protected]>
 Michael Bernstein <[email protected]>
 Michael Dawson <[email protected]> <[email protected]>
 Michael Dawson <[email protected]> <[email protected]>
@@ -379,6 +385,7 @@ Qingyu Deng <[email protected]> <[email protected]>
 Rachel White <[email protected]>
 Ratikesh Misra <[email protected]>
 Ravindra Barthwal <[email protected]>
+Ray <[email protected]> <[email protected]>
 Ray Morgan <[email protected]>
 Ray Solomon <[email protected]>
 Raymond Feng <[email protected]> <[email protected]>
@@ -528,6 +535,8 @@ xiaoyu <[email protected]>
 Xu Meng <[email protected]> <[email protected]>
 Yael Hermon <[email protected]> <[email protected]>
 Yang Guo <[email protected]>
+Yash Ladha <[email protected]> <[email protected]>
+Yash Ladha <[email protected]> <[email protected]>
 ycjcl868 <[email protected]> <[email protected]>
 Yingchen Xue <[email protected]>
 Yongsheng Zhang <[email protected]>

AUTHORS

@@ -3027,7 +3027,7 @@ Christian Niederer <[email protected]>
 Sk Sajidul Kadir <[email protected]>
 Bartlomiej Brzozowski <[email protected]>
 Saajan <[email protected]>
-Yash Ladha <[email protected]>
+Yash Ladha <[email protected]>
 Alex R <[email protected]>
 Hachimi Aa (Sfeir) <[email protected]>
 Daniel Estiven Rico Posada <[email protected]>
@@ -3220,7 +3220,7 @@ Akash Negi <[email protected]>
 James Addison <[email protected]>
 Fabian Cook <[email protected]>
 Kalvin Vasconcellos <[email protected]>
-marsonya <[email protected]>
+Akhil Marsonya <[email protected]>
 Qingyu Deng <[email protected]>
 Matin Zadehdolatabad <[email protected]>
 Daniel Clark <[email protected]>
@@ -3272,7 +3272,7 @@ Arnold Zokas <[email protected]>
 Nils Dralle <[email protected]>
 Jesse Chan <[email protected]>
 helloyou2012 <[email protected]>
-MrJithil <[email protected]>
+Jithil P Ponnan <[email protected]>
 Rodolfo Carvalho <[email protected]>
 Jordan Baczuk <[email protected]>
 moander <[email protected]>
@@ -3310,7 +3310,7 @@ nerdthatnoonelikes <[email protected]>
 Nikita Rykov <[email protected]>
 Benjamin Mayr <[email protected]>
 Lew Gordon <[email protected]>
-Mestery <mestery@pm.me>
+Mestery <mestery@protonmail.com>
 Himadri Ganguly <[email protected]>
 Howie Zhao <[email protected]>
 Luan Devecchi <[email protected]>
@@ -3319,7 +3319,7 @@ Justin <[email protected]>
 Raz Luvaton <[email protected]>
 Don Jayamanne <[email protected]>
 Felix Yan <[email protected]>
-Ray <[email protected]>
+Ray <[email protected]>
 Node.js GitHub Bot <[email protected]>
 Alexey Ten <[email protected]>
 JckXia <[email protected]>
@@ -3396,5 +3396,22 @@ Wayne Zhang <[email protected]>
 nikoladev <[email protected]>
 Antonio Román <[email protected]>
 JoostK <[email protected]>
+Yu <[email protected]>
+Shi Pujin <[email protected]>
+Daoming Qiu <[email protected]>
+Job <[email protected]>
+Alex Agranov <[email protected]>
+Shalvah <[email protected]>
+Gabriel Trujillo <[email protected]>
+LiviaMedeiros <[email protected]>
+iMoses <[email protected]>
+Harshil jain <[email protected]>
+Tobias Hernstig <[email protected]>
+Ben McCann <[email protected]>
+Caio Agiani <[email protected]>
+Ateş Göral <[email protected]>
+Tony Gorez <[email protected]>
+ofirbarak <[email protected]>
+Bar Admoni <[email protected]>
 
 # Generated by tools/update-authors.js

BUILDING.md

@@ -219,9 +219,10 @@ Supported platforms and toolchains change with each major version of Node.js.
 This document is only valid for the current major version of Node.js.
 Consult previous versions of this document for older versions of Node.js:
 
+* [Node.js 17](https://github.com/nodejs/node/blob/v17.x/BUILDING.md)
+* [Node.js 16](https://github.com/nodejs/node/blob/v16.x/BUILDING.md)
 * [Node.js 14](https://github.com/nodejs/node/blob/v14.x/BUILDING.md)
 * [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md)
-* [Node.js 10](https://github.com/nodejs/node/blob/v10.x/BUILDING.md)
 
 ## Building Node.js on supported platforms
 

CONTRIBUTING.md

@@ -5,28 +5,28 @@
 * [Pull Requests](#pull-requests)
 * [Developer's Certificate of Origin 1.1](#developers-certificate-of-origin)
 
-## [Code of Conduct](./doc/guides/contributing/code-of-conduct.md)
+## [Code of Conduct](./doc/contributing/code-of-conduct.md)
 
 The Node.js project has a
 [Code of Conduct](https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md)
 to which all contributors must adhere.
 
-See [details on our policy on Code of Conduct](./doc/guides/contributing/code-of-conduct.md).
+See [details on our policy on Code of Conduct](./doc/contributing/code-of-conduct.md).
 
-## [Issues](./doc/guides/contributing/issues.md)
+## [Issues](./doc/contributing/issues.md)
 
-* [Asking for General Help](./doc/guides/contributing/issues.md#asking-for-general-help)
-* [Discussing non-technical topics](./doc/guides/contributing/issues.md#discussing-non-technical-topics)
-* [Submitting a Bug Report](./doc/guides/contributing/issues.md#submitting-a-bug-report)
-* [Triaging a Bug Report](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+* [Asking for General Help](./doc/contributing/issues.md#asking-for-general-help)
+* [Discussing non-technical topics](./doc/contributing/issues.md#discussing-non-technical-topics)
+* [Submitting a Bug Report](./doc/contributing/issues.md#submitting-a-bug-report)
+* [Triaging a Bug Report](./doc/contributing/issues.md#triaging-a-bug-report)
 
-## [Pull Requests](./doc/guides/contributing/pull-requests.md)
+## [Pull Requests](./doc/contributing/pull-requests.md)
 
-* [Dependencies](./doc/guides/contributing/pull-requests.md#dependencies)
-* [Setting up your local environment](./doc/guides/contributing/pull-requests.md#setting-up-your-local-environment)
-* [The Process of Making Changes](./doc/guides/contributing/pull-requests.md#the-process-of-making-changes)
-* [Reviewing Pull Requests](./doc/guides/contributing/pull-requests.md#reviewing-pull-requests)
-* [Notes](./doc/guides/contributing/pull-requests.md#notes)
+* [Dependencies](./doc/contributing/pull-requests.md#dependencies)
+* [Setting up your local environment](./doc/contributing/pull-requests.md#setting-up-your-local-environment)
+* [The Process of Making Changes](./doc/contributing/pull-requests.md#the-process-of-making-changes)
+* [Reviewing Pull Requests](./doc/contributing/pull-requests.md#reviewing-pull-requests)
+* [Notes](./doc/contributing/pull-requests.md#notes)
 
 <a id="developers-certificate-of-origin"></a>
 

GOVERNANCE.md

@@ -25,7 +25,7 @@ Triagers are given the "Triage" GitHub role and have:
 See:
 
 * [List of triagers](./README.md#triagers)
-* [A guide for triagers](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+* [A guide for triagers](./doc/contributing/issues.md#triaging-a-bug-report)
 
 ## Collaborators
 
@@ -54,7 +54,7 @@ result in collaborators removing their opposition.
 See:
 
 * [List of collaborators](./README.md#current-project-team-members)
-* [A guide for collaborators](./doc/guides/collaborator-guide.md)
+* [A guide for collaborators](./doc/contributing/collaborator-guide.md)
 
 ### Collaborator activities