Skip to content

Conversation

bengl
Copy link
Member

@bengl bengl commented Feb 24, 2022

Adds Bryan English and his public key to the README for releases.

Adds Bryan English and his public key to the README for releases.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 24, 2022
@Trott
Copy link
Member

Trott commented Feb 24, 2022

Is the most recent release signed with this key? If so, I suppose we might want to fast-track so that someone checking the integrity of a download doesn't fail to find the relevant key in the README file.

@bengl
Copy link
Member Author

bengl commented Feb 24, 2022

@Trott No, it was signed by @BethGriggs as per https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#adding-new-releasers

@richardlau richardlau added lts-watch-v12.x notable-change PRs with changes that should be highlighted in changelogs. labels Feb 24, 2022
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bengl added a commit that referenced this pull request Feb 26, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
@bengl
Copy link
Member Author

bengl commented Feb 26, 2022

Landed in bcc523e

@bengl bengl closed this Feb 26, 2022
bengl added a commit that referenced this pull request Feb 26, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
bengl added a commit that referenced this pull request Feb 26, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
bengl added a commit that referenced this pull request Feb 26, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
bengl added a commit that referenced this pull request Feb 26, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
bengl added a commit to bengl/docker-node that referenced this pull request Feb 26, 2022
bengl added a commit to bengl/docker-node that referenced this pull request Feb 26, 2022
danielleadams added a commit that referenced this pull request Mar 3, 2022
Notable changes:

* module:
  * unflag esm json modules (Geoffrey Booth) #41736
* doc:
  * add release key for Bryan English (Bryan English) #42102
sxa added a commit to sxa/node that referenced this pull request Mar 9, 2022
Notable changes:

* (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) nodejs#42093
* (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) nodejs#41310
* (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) nodejs#35025
* doc: add release key for Bryan English (Bryan English) nodejs#42102

Dependency Updates:

* deps: update nghttp2 to 1.47.0 (Yash Ladha) nodejs#42127
* deps: upgrade npm to 8.5.2 (npm team) nodejs#42122

New Collaborators:

* doc: add JakobJingleheimer to collaborators list (Jacob Smith) nodejs#42185
* doc: move bnoordhuis back to collaborators (Ben Noordhuis) nodejs#42064

PR-URL: nodejs#42254
BethGriggs pushed a commit that referenced this pull request Mar 9, 2022
Notable changes:

* (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093
* (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) #41310
* (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #35025
* doc: add release key for Bryan English (Bryan English) #42102

Dependency Updates:

* deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127
* deps: upgrade npm to 8.5.2 (npm team) #42122

New Collaborators:

* doc: add JakobJingleheimer to collaborators list (Jacob Smith) #42185
* doc: move bnoordhuis back to collaborators (Ben Noordhuis) #42064

PR-URL: #42254
danielleadams added a commit that referenced this pull request Mar 11, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102
danielleadams added a commit that referenced this pull request Mar 14, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102
danielleadams added a commit that referenced this pull request Mar 14, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102
danielleadams added a commit that referenced this pull request Mar 15, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102

PR-URL: #42200
danielleadams added a commit that referenced this pull request Mar 15, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102

PR-URL: #42200
richardlau pushed a commit that referenced this pull request Mar 15, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
danielleadams added a commit that referenced this pull request Mar 16, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102

PR-URL: #42200
richardlau pushed a commit that referenced this pull request Mar 16, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 17, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 17, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
@richardlau richardlau mentioned this pull request Mar 30, 2022
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Adds Bryan English and his public key to the README for releases.

PR-URL: nodejs#42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Notable changes:

* (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) nodejs#42093
* (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) nodejs#41310
* (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) nodejs#35025
* doc: add release key for Bryan English (Bryan English) nodejs#42102

Dependency Updates:

* deps: update nghttp2 to 1.47.0 (Yash Ladha) nodejs#42127
* deps: upgrade npm to 8.5.2 (npm team) nodejs#42122

New Collaborators:

* doc: add JakobJingleheimer to collaborators list (Jacob Smith) nodejs#42185
* doc: move bnoordhuis back to collaborators (Ben Noordhuis) nodejs#42064

PR-URL: nodejs#42254
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) nodejs#42102

PR-URL: nodejs#42200
juanarbol added a commit that referenced this pull request May 1, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v16.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
@juanarbol juanarbol mentioned this pull request May 1, 2022
juanarbol added a commit that referenced this pull request May 1, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v16.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 2, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (@devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 4, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 4, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.