Skip to content

lib: throw error in structuredClone when no arguments are passed #41651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2022
Merged

lib: throw error in structuredClone when no arguments are passed #41651

merged 3 commits into from
Jan 24, 2022

Conversation

gioragutt
Copy link
Contributor

Throw TypeError on structuredClone().

Fixes: #41450

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 22, 2022
VoltrexKeyva
VoltrexKeyva reviewed Jan 22, 2022
View reviewed changes
@gioragutt @VoltrexKeyva
Update lib/internal/structured_clone.js
e8d0d9c 
copy-pasta is strong

Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42098/

Mesteery
Mesteery reviewed Jan 23, 2022
View reviewed changes
@aduh95 aduh95 changed the title lib: throw error in structuedClone when no arguments are passed lib: throw error in structuredClone when no arguments are passed Jan 23, 2022
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42119/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42120/

@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit b27ae24 into nodejs:master Jan 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b27ae24

@benjamingr
Copy link
Member

Congrats on another contribution @gioragutt - now for the next one :)

@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Open
28 tasks
@gioragutt gioragutt deleted the giorag/structured-clone-no-arguments-error branch January 25, 2022 08:57
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Open
26 tasks
This was referenced Jan 27, 2022
Open
Open
Open
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@gioragutt @Linkgoron
lib: throw error in structuedClone when no arguments are passed
0192c02 
PR-URL: nodejs#41651
Fixes: nodejs#41450
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@gioragutt @ruyadorno
lib: throw error in structuedClone when no arguments are passed
8ab0540 
PR-URL: #41651
Fixes: #41450
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

structuredClone / atob / btoa should throw a TypeError without arguments
8 participants
@gioragutt @nodejs-github-bot @benjamingr @RaisinTen @Mesteery @VoltrexKeyva @targos @danielleadams