Skip to content

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Mar 22, 2021

Original commit from https://chromium-review.googlesource.com/c/v8/v8/+/2757901:

[top-level-await] Implement the new post-order requirement for async subgraphs

This CL implements
https://github.com/tc39/proposal-top-level-await/pull/159, which reached
consensus at the March 2021 TC39.

The high-level intent is for parent modules that depend on async modules
to remember the DFS post-order such that when their async dependency
finishes, they execute in that original post-order. This aligns the
ordering between completely sync module graphs and async module graphs.

Bug: v8:11557
Change-Id: I5bd8f38f040115c255ca1ce8253b9686fdb4af03
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757901
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73551}

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 22, 2021
@guybedford guybedford changed the title deps: V8 backport for 9689b17687 deps: V8 backport for f19142e6 Mar 22, 2021
@guybedford guybedford requested a review from targos March 22, 2021 16:50
@targos
Copy link
Member

targos commented Mar 22, 2021

Please add Refs: https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec to the commit message

@targos
Copy link
Member

targos commented Mar 22, 2021

Note to whoever lands this: the embedder string should be incremented.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2021

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

guybedford added a commit that referenced this pull request Mar 29, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

PR-URL: #37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in 0c5f9bb.

@guybedford guybedford closed this Mar 29, 2021
guybedford added a commit that referenced this pull request Mar 29, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit that referenced this pull request Mar 29, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 29, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno
Copy link
Member

Looks like this got modified after landing, updated commit in master is 8e46568

@ruyadorno
Copy link
Member

This doesn't land cleanly in v15.x-staging.

guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@guybedford
Copy link
Contributor Author

Backports are #37985 for 15 and #37973 for 14. Both required a little manual work.

guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 31, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37985
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Mar 31, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Apr 1, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit to guybedford/node that referenced this pull request Apr 8, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit that referenced this pull request Apr 14, 2021
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37973
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants