perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN #36937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Jan 15, 2021
RaisinTen
added
the
author ready
jasnell
approved these changes
Jan 15, 2021
cjihrig
approved these changes
Jan 15, 2021
|
Landed in 59af4e6 |
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 25, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
… is NaN Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36936