build: enable building with shared uvwasi lib #36257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
I was not able to test it successfully because it needs a external library . please suggest |
richardlau
reviewed
Nov 25, 2020
|
@richardlau -I get this error and don't know how to resolve this. /usr/bin/ld: /home/pooja/node/out/Release/obj.target/libnode/src/node_binding.o: in function `node::binding::RegisterBuiltinModules()':
node_binding.cc:(.text+0x150a): undefined reference to `_register_wasi()'
collect2: error: ld returned 1 exit status``` |
PoojaDurgad
force-pushed
the
config-uvwasi
branch
from
8c83c4c to
ffe4717
Compare
richardlau
reviewed
Nov 25, 2020
PoojaDurgad
force-pushed
the
config-uvwasi
branch
from
55737ca to
0e4eae8
Compare
richardlau
reviewed
Nov 26, 2020
PoojaDurgad
force-pushed
the
config-uvwasi
branch
from
6cb19d1 to
e9f38a3
Compare
Trott
reviewed
Nov 28, 2020
|
If GitHub Actions are to be trusted, this breaks the build in its current state.
|
|
I changed this to a draft. Feel free to change it back whenever you think it's ready, but I'd guess it's a draft until the build is working. |
Fixes: nodejs#35339 Co-authored-by: Pooja D P <[email protected]> Co-authored-by: Teutates <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
added
the
author ready
|
Superseded by #43987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35339
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes