doc: complete n-api version matrix #32304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues.
gabrielschulhof
added
doc
cjihrig
approved these changes
Mar 16, 2020
richardlau
approved these changes
Mar 16, 2020
|
Tangentially I presume we'll need to do something to add a row for 14.0.0 when it is released? |
|
@richardlau and a column for N-API 6 soon. |
lpinca
approved these changes
Mar 16, 2020
legendecas
reviewed
Mar 17, 2020
| | v10.x | v10.0.0 | v10.0.0 | v10.0.0 | v10.16.0 | v10.17.0 | | ||
| | v11.x | v11.0.0 | v11.0.0 | v11.0.0 | v11.8.0 | | | ||
| | v12.x | v12.0.0 | v12.0.0 | v12.0.0 | v12.0.0 | v12.11.0 | | ||
| | v13.x | v13.0.0 | v13.0.0 | v13.0.0 | v13.0.0 | v13.0.0 | |
There was a problem hiding this comment.
Maybe a new column of N-API version 6 can be added too?
legendecas
approved these changes
Mar 17, 2020
trivikr
approved these changes
Mar 18, 2020
jasnell
approved these changes
Mar 18, 2020
jasnell
pushed a commit
that referenced
this pull request
Mar 18, 2020
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: #32304 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in b2d3466 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: #32304 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: #32304 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: nodejs#32304 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: #32304 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have received feedback indicating that the N-API support matrix as
present now can be misinterpreted to mean that old versions of N-API
are no longer supported on newer versions of Node.js. Filling out the
bottom of the matrix should hopefully make it clear that support for
such old versions continues.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes