src: add missing namespace using statements in node_watchdog.h #32117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although these `using`s can derived from other header files, it will be better to be self-contained.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Mar 6, 2020
jasnell
approved these changes
Mar 6, 2020
devnexen
approved these changes
Mar 6, 2020
richardlau
approved these changes
Mar 6, 2020
richardlau
added
the
author ready
addaleax
approved these changes
Mar 6, 2020
addaleax
pushed a commit
that referenced
this pull request
Mar 9, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in e70705c |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
|
Depends on #29207 to land on v12.x |
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: nodejs#32117 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although these
usings can derived from other header files, it willbe better to be self-contained.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes