crypto: automatically manage memory for ECDSA_SIG #30641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
cjihrig
approved these changes
Nov 25, 2019
This comment has been minimized.
This comment has been minimized.
devnexen
approved these changes
Nov 26, 2019
bnoordhuis
approved these changes
Nov 26, 2019
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Nov 27, 2019
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Refs: #29292 PR-URL: #30641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in f6a4a36 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Refs: #29292 PR-URL: #30641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Refs: #29292 PR-URL: #30641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
tniessen
deleted the
crypto-use-automatic-memory-management-for-ecdsasig
branch
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Refs: #29292 PR-URL: #30641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @bnoordhuis in #29292.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes