Skip to content

util: improve debuglog performance #28956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

util: improve debuglog performance #28956

merged 1 commit into from
Aug 9, 2019

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Aug 4, 2019 •
edited
Loading

Sample results:

 streams/pipe-object-mode.js n=5000000                        ***     14.74 %       ±1.49% ±1.99%  ±2.60%
 streams/pipe.js n=5000000                                    ***     14.54 %       ±2.10% ±2.79%  ±3.64%
 streams/readable-bigread.js n=1000                           ***      7.85 %       ±1.15% ±1.53%  ±1.99%
 streams/readable-boundaryread.js type='buffer' n=2000        ***     28.70 %       ±1.95% ±2.60%  ±3.40%
 streams/readable-boundaryread.js type='string' n=2000        ***      6.98 %       ±1.55% ±2.07%  ±2.70%
 streams/readable-readall.js n=5000                           ***      7.49 %       ±1.61% ±2.14%  ±2.79%
 streams/readable-unevenread.js n=1000                        ***      9.55 %       ±1.41% ±1.87%  ±2.44%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mscdex mscdex added util Issues and PRs related to the built-in util module. performance Issues and PRs related to the performance of Node.js. labels Aug 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24841/

@mscdex
util: improve debuglog performance
ef01d7c 
PR-URL: nodejs#28956
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@mscdex mscdex merged commit ef01d7c into nodejs:master Aug 9, 2019
@mscdex mscdex deleted the debuglog-perf branch August 9, 2019 22:20
targos pushed a commit that referenced this pull request Aug 19, 2019
@mscdex @targos
util: improve debuglog performance
a4e2549 
PR-URL: #28956
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mscdex @nodejs-github-bot @jasnell @antsmartian @targos @cjihrig @joyeecheung @devsnek @trivikr