doc: format Unix consistently #28576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Jul 6, 2019
lpinca
approved these changes
Jul 6, 2019
Agreed. It's a bit annoying that the doc rules exist outside of core. |
gireeshpunathil
approved these changes
Jul 6, 2019
Trott
approved these changes
Jul 6, 2019
addaleax
approved these changes
Jul 6, 2019
Yeah, I'd be for reversing the flow to make this easier on us. In other words, instead of adding a rule to the That might also involve undoing some or all of the rollup stuff for lint-md too, though. |
cjihrig
added
the
author ready
BridgeAR
approved these changes
Jul 8, 2019
Update the API docs to always spell as Unix. PR-URL: nodejs#28576 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
Update the API docs to always spell as Unix. PR-URL: #28576 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API docs to always spell as Unix for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes