Skip to content

assert,test: complete coverage for AssertionError #27635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/internal/assert/assertion_error.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ let white = '';

const kReadableOperator = {
deepStrictEqual: 'Expected values to be strictly deep-equal:',
equal: 'Expected values to be loosely equal:',
notEqualUnequal: 'Expected values not to be loosely equal:',
strictEqual: 'Expected values to be strictly equal:',
strictEqualObject: 'Expected "actual" to be reference-equal to "expected":',
deepEqual: 'Expected values to be loosely deep-equal:',
Expand Down
27 changes: 27 additions & 0 deletions test/parallel/test-assert-assertion-error.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';
require('../common');

// Test some edge cases for AssertionError that are not tested elsewhere.
const assert = require('assert');

{
const err = new assert.AssertionError({ operator: 'equal',
actual: 'come on',
expected: 'fhqwhgads',
});

assert.strictEqual(err.message,
"Expected values to be loosely equal:\n\n'come on'\n\n" +
"should loosely equal\n\n'fhqwhgads'");
}

{
const err = new assert.AssertionError({ operator: 'notEqual',
actual: 'come on',
expected: 'fhqwhgads',
});

assert.strictEqual(err.message,
'Expected values not to be loosely equal:\n\n' +
"'come on'\n\nshould not loosely equal\n\n'fhqwhgads'");
}