Skip to content

Conversation

gengjiawen
Copy link
Member

See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-emplace.html

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 10, 2019
@BridgeAR
Copy link
Member

@gengjiawen gengjiawen force-pushed the clang-tidy-emplace branch 2 times, most recently from 407cfb7 to f571048 Compare March 11, 2019 14:52
@danbev
Copy link
Contributor

danbev commented Mar 14, 2019

@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 21, 2019

@danbev Can you import this and #26585, thanks.

@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

Landed in f091d4e.

@targos
Copy link
Member

targos commented Mar 28, 2019

Compilation fails if this is applied on v11.x-staging:

make -C out BUILDTYPE=Release V=
  TOUCH cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  ACTION _home_mzasso_git_nodejs_v11_x_deps_v8_gypfiles_v8_gyp_v8_torque_host_run_torque cbca18b98112d8bc68a52ca94d8199523305cf11.intermediate
  TOUCH b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  ACTION Generating inspector protocol sources from protocol json b4eb7431cd5126f82ef689c4118ba80414d6aa1b.intermediate
  TOUCH 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  ACTION Generating node protocol sources from protocol json 3c3044250b6b8174e7fa6ce999544ccc88deb4fe.intermediate
  CXX(target) /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o
../src/inspector_socket.cc: In static member function ‘static int node::inspector::{anonymous}::HttpHandler::OnMessageComplete(parser_t*)’:
../src/inspector_socket.cc:570:43: error: cannot bind bitfield ‘parser->http_parser::upgrade’ to ‘unsigned int&’
                                   parser->upgrade,
                                   ~~~~~~~~^~~~~~~
make[1]: *** [node_lib.target.mk:340: /home/mzasso/git/nodejs/v11.x/out/Release/obj.target/node_lib/src/inspector_socket.o] Error 1

Please open a backport PR or apply the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants