Skip to content

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 9, 2019

Prefer structured output over stringified information
for libuv handles and the native stack trace.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Prefer structured output over stringified information
for libuv handles and the native stack trace.
@addaleax addaleax requested a review from cjihrig February 9, 2019 23:13
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 9, 2019
@addaleax addaleax assigned addaleax and unassigned addaleax Feb 9, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 9, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20700/ (:heavy_check_mark:)

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Side note - keeping the example report in the docs up to date is becoming a bit of a pain 😄

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member Author

Landed in 2c84f6e

@addaleax addaleax closed this Feb 11, 2019
@addaleax addaleax deleted the report-prog branch February 11, 2019 23:56
addaleax added a commit that referenced this pull request Feb 11, 2019
Prefer structured output over stringified information
for libuv handles and the native stack trace.

PR-URL: #26019
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Feb 13, 2019
Prefer structured output over stringified information
for libuv handles and the native stack trace.

PR-URL: #26019
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants