src: use std::vector for setting up process.execPath #25069
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `std::vector` as an RAII-style alternative to allocating and deleting raw memory storage.
nodejs-github-bot
added
the
c++
richardlau
approved these changes
Dec 15, 2018
|
Commit message linter failure is bogus. Have opened nodejs/core-validate-commit#40. |
joyeecheung
approved these changes
Dec 16, 2018
cjihrig
approved these changes
Dec 16, 2018
lpinca
approved these changes
Dec 16, 2018
|
Is there a reason why we can't statically allocate the memory, given that |
jasnell
approved these changes
Dec 17, 2018
|
Landed in 0461e4c. |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Dec 21, 2018
Use `std::vector` as an RAII-style alternative to allocating and deleting raw memory storage. PR-URL: nodejs#25069 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
Use `std::vector` as an RAII-style alternative to allocating and deleting raw memory storage. PR-URL: #25069 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Use `std::vector` as an RAII-style alternative to allocating and deleting raw memory storage. PR-URL: #25069 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Use `std::vector` as an RAII-style alternative to allocating and deleting raw memory storage. PR-URL: nodejs#25069 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace-adjusted diff for review: https://github.com/nodejs/node/pull/25069/files?w=1
Use
std::vectoras an RAII-style alternative to allocatingand deleting raw memory storage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes