tls: disable TLS v1.0 and v1.1 by default#23814
Closed
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Closed
tls: disable TLS v1.0 and v1.1 by default#23814bnoordhuis wants to merge 2 commits intonodejs:masterfrom
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://blog.mozilla.org/security/2018/10/15/removing-old-versions-of-tls/
Firefox will drop support for TLS < 1.2 in March 2020. Given the usage numbers, I'd say that makes sense. This PR is a discussion starter about when to disable it in Node.js.
v12 will be released in April 2019. That might be too early. But v12 is supported until April 2022. That's too late. So what is a good time?
Users can programmatically re-enable TLS 1.0 and 1.1 with this PR. To what extent does that alleviate backwards compatibility concerns? Would a command line flag be better?