src: some refactoring of node_zlib.cc #23019
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in order to avoid having two separate definitions for `node_zlib_mode`.
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 22, 2018
devsnek
approved these changes
Sep 23, 2018
danbev
pushed a commit
that referenced
this pull request
Sep 25, 2018
PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
danbev
pushed a commit
that referenced
this pull request
Sep 25, 2018
PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
danbev
pushed a commit
that referenced
this pull request
Sep 25, 2018
This is in order to avoid having two separate definitions for `node_zlib_mode`. PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 25, 2018
PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 25, 2018
PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 25, 2018
This is in order to avoid having two separate definitions for `node_zlib_mode`. PR-URL: #23019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes