Skip to content

lib: set Symbol.toStringTag of DOMException #22933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lib: set Symbol.toStringTag of DOMException #22933

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Refs: #22550

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/929/pipeline

@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17291/

@joyeecheung joyeecheung changed the title test: set Symbol.toStringTag of DOMException lib: set Symbol.toStringTag of DOMException Sep 18, 2018
@joyeecheung joyeecheung mentioned this pull request Sep 18, 2018
Closed
3 tasks
@joyeecheung
Copy link
Member Author

CI is green

@joyeecheung
Copy link
Member Author

landed in f91716f, thanks!

joyeecheung added a commit that referenced this pull request Sep 20, 2018
@joyeecheung
lib: set Symbol.toStringTag of DOMException
f91716f 
PR-URL: #22933
Refs: #22550
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 21, 2018
@joyeecheung @targos
lib: set Symbol.toStringTag of DOMException
5e7b108 
PR-URL: #22933
Refs: #22550
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+3 more reviewers

@jdalton jdalton jdalton approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@joyeecheung @nodejs-github-bot @jdalton @jasnell @addaleax @lpinca @TimothyGu @cjihrig @devsnek @BridgeAR