build: make doc generation work on Windows #22749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Member
Author
|
Please 👍 here to approve fast-tracking. |
richardlau
approved these changes
Sep 7, 2018
refack
approved these changes
Sep 7, 2018
Contributor
|
/CC @nodejs/platform-windows @nodejs/build-files |
BridgeAR
approved these changes
Sep 7, 2018
jasnell
approved these changes
Sep 7, 2018
Member
Author
|
Landed in 3f67190. |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Sep 8, 2018
PR-URL: nodejs#22749 Refs: nodejs#21697 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 9, 2018
PR-URL: #22749 Refs: #21697 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21697 broke doc generation on Windows since the option name for the output directory was incorrect.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes