Skip to content

net: use object destructoring for errors #21050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

net: use object destructoring for errors #21050

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 31, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label May 31, 2018
@danbev
Copy link
Contributor Author

danbev commented May 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15176/

@tniessen
Copy link
Member

Node.js collaborators, please 👍 here to approve fast-tracking.

@starkwang
Copy link
Contributor

This change may be duplicated with #20959.

@apapirovski
Copy link
Contributor

@danbev I'm going to close this out, if you don't mind as I'm landing #20959 which has this exact change.

@apapirovski apapirovski closed this Jun 1, 2018
@danbev
Copy link
Contributor Author

danbev commented Jun 1, 2018

@apapirovski Perfect, thanks.

@danbev danbev deleted the net_object_destr_errors branch August 20, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @tniessen @starkwang @apapirovski @jasnell @trivikr @nodejs-github-bot