doc: add link & simplify data event (net.Socket)#19487
Closed
boneskull wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add link & simplify data event (net.Socket)#19487boneskull wants to merge 1 commit intonodejs:masterfrom
boneskull wants to merge 1 commit intonodejs:masterfrom
Conversation
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
nodejs-github-bot
added
doc
jasnell
approved these changes
Mar 20, 2018
trivikr
approved these changes
Mar 25, 2018
Member
trivikr
pushed a commit
to trivikr/node
that referenced
this pull request
Mar 25, 2018
PR-URL: nodejs#19487 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Landed in df0a37a |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19487 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a more specific link from the docs for
net.Socket'sdataevent tosocket.setEncoding(), which in turn links to the readable stream docs for more info. It removes the link directly to the readable stream docs.It also fixes a misnamed link (
stream.setEncodingwhen should bereadable.setEncoding)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes