test: remove unused using declarations #18637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danbev please always trigger a CI after creating a PR :-) |
BridgeAR
added
fast-track
|
I’m on a train at the moment and the connection is a little flakey so I was
not able to start when I tried before.
tors 8 feb. 2018 kl. 12:44 skrev Ruben Bridgewater <[email protected]
…:
@danbev <https://github.com/danbev> please always trigger a CI after
creating a PR :-)
CI https://ci.nodejs.org/job/node-test-pull-request/13034/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18637 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAaY32t_HXxsH7f3D_Jq4LIBSVjr2jSUks5tSt4PgaJpZM4R-BIh>
.
|
cjihrig
approved these changes
Feb 8, 2018
jasnell
approved these changes
Feb 9, 2018
tniessen
approved these changes
Feb 10, 2018
|
Landed in cf52ab1 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
PR-URL: nodejs#18637 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
PR-URL: nodejs#18637 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Seems like some of these declarations are still being used in v9.x I've set as don't land for simplicity, but feel free to change labels and backport |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18637 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test