build: set disable_glibcxx_debug flag#16159
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two.
nodejs-github-bot
added
the
build
bnoordhuis
approved these changes
Oct 12, 2017
fhinkel
approved these changes
Oct 12, 2017
jasnell
approved these changes
Oct 12, 2017
Member
Author
|
Probably doesn’t matter, but: CI: https://ci.nodejs.org/job/node-test-commit/13153/ |
Member
Author
|
Landed in cc443cb |
addaleax
added a commit
that referenced
this pull request
Oct 15, 2017
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: #16159 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
added a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: nodejs/node#16159 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: #16159 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
Should this be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks a few tests when Node is built in debug mode, because V8 is built with
-D_GLIBCXX_DEBUG=1and Node is built without, which makes e.g.std::vectorABI-incompatible between the two../node_g test/parallel/test-cli-node-options.jsif you want to try it. :)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build